This is an archive of past discussions. Do not edit the contents of this page. If you wish to start a new discussion or revive an old one, please do so on the current talk page.

Hi,I'm back with 2 minor bugs on the banners:

1. The banner template doesn't works on help or wikivoyage pages (exemple: fr:Aide:Ajouter une image).
2. The banner doesn't display the TOC if there are less than 4 subtibles. It doesn't affect a lot of pages but in tematic pages articles with less sections exist (exemple: fr:Patrimoine mondial au Bangladesh).

I wish the best for the new year and hope you have answers to my questions...--Adehertogh (talk) 17:45, 4 January 2016 (UTC)[reply]

The table of contents is not displayed on any Mediawiki article with less than four headings - that is true whether a pagebanner is used or not. You can force a TOC to appear by adding __FORCETOC__ to the article - see mw:Manual:Table of contents#Adding the TOC for more information. As to the banner not appearing for certain namespaces, trying pinging User:Jdlrobson for help - for some reason I think the banner was set up not to display in certain namespaces, but I don't know why that is; he can resolve the issue with a configuration change to the banner plugin. -- Ryan • (talk) • 03:29, 5 January 2016 (UTC)[reply]

calling me a vandal. When i add good entries. Don't lead others like traveler100 etc --DumfriesNative (talk) 20:08, 5 January 2016 (UTC)[reply]

I'am going to try and contact the creators of wikitravel wikivoyage and ask them to prevent you from deleting my listings! You have been warned this is getting old Ryan very. --DumfriesNative (talk) 20:19, 5 January 2016 (UTC)[reply]

Excuse me, please! My move Wikivoyage:Policies is mystake. I was loocked to namespaces in Wikivoyage and I was pressed "Move page". This is mistake. Thank you for revert! Excuse me, please! --MDsmajlik (talk) 14:54, 23 January 2016 (UTC)[reply]

• I have to admit that I haven't reread important policy pages as often as I should, and that I get very annoyed when I come across what I judge to be vandalism, childisness, and disrespect to our beloved travel guides. The precedent shall not be set. I promise to take the time to consult policy before acting, instead of doing impulsive things, from now on. Ibaman (talk) 17:35, 29 January 2016 (UTC)[reply]

• As I explain my blocking action, I have a doubt to clarify, Ryan. I have always maintained the practice of blocking every IP number that re-posts touty stuff, and marking it as "spambot", as it's not vandalism and it's not intimidating behaviour, either. The definition of "Spambot" includes anonymous touty IP numbers, in my opinion. That was the reason of my action. Ibaman (talk) 15:54, 2 February 2016 (UTC)[reply]
  • That's not at all what a spambot is. You can't just redefine words like that. "Bot" means it's automated. Powers ^(talk) 15:59, 2 February 2016 (UTC)[reply]

Ibaman, two very important points per WV:How to handle unwanted edits: 1) an automated spambot is an automated script, not a real person, and we have guidelines for handling them, and 2) as pointed out previously, there is an agreed-upon process for handling touts. Blocking someone after two edits without giving them a talk page warning violates our policy and is abuse of your admin privileges. I'm not sure if you are understanding that not following site policies when applying blocks is a very, very big deal, and the repeated issues are becoming a serious concern. -- Ryan • (talk) • 16:23, 2 February 2016 (UTC)[reply]

I understand it. It's embarrassing to me, to be a cause of concern to the fellow Wikivoyagers, to cause the fellow editors to point to me unpleasant consequences of my overzealness. My bad. All I care about is the writing and maintenance of great travel guide pages. About mistaking the meaning of "spambot", sorry again. English is not my first language and every now and then I get to embarrass myself with this kind of situation. Ibaman (talk) 16:40, 2 February 2016 (UTC)[reply]

Please understand that your contributions are very much appreciated, and I definitely don't mean to embarrass you. My concern is simply that our policies are designed around the idea that we should be making an effort to educate users who make unwanted edits, and blocking is only done when other efforts have failed. -- Ryan • (talk) • 16:48, 2 February 2016 (UTC)[reply]

Did we ever come up with any kind of process for including good users in the patroller group? If so, please point me in that direction. If not, we should give patroller rights to User:ThunderingTyphoons!. I'll drop him a line to see if he's interested in a new admin nomination (his nomination two years ago resulted in not yet), but the patroller rights should be uncontroversial in the mean time. Can you do that? JuliasTravels (talk) 15:17, 20 February 2016 (UTC)[reply]

I've updated the user rights to add patroller. -- Ryan • (talk) • 15:21, 20 February 2016 (UTC)[reply]

• I noticed that you are checking out articles with no geo templates and thought you might like to if ou want to test, try out or experiment with my Module:Sandbox/Matroc -- function makegeo - it has been revised somewhat
  • to format lat and long to 6 decimal places.
  • to remove trailing zeroes.
  • was going to add "zoom" but left that out as I think there is a default zoom - can always add it if needed
• To use
  • edit the section in article where you want geo template to appear
  • add following {{safesubst:#invoke:Sandbox/Matroc|makegeo}}
    • this will look up the wikidata record
  • click preview and you will see the map icon
    • if you don't use safesubst - {{#invoke:Sandbox/Matroc|makegeo}} you will just get the template output as a string and not the map - This is an issue with using Modules and maps and timing so its best to use safesubst in order to have the results needed.
  • open map (icon) in another tab and you should see the results.
  • if nothing (no map icon) is returned that means there is no latitudes or longitude to be found in wikidata
  • Go ahead and verify the coordinates and if everything is ok then save the article otherwise you can just cancel the edit.
    • You can if nothing is found find coordinates by some other means and create the geo template.

Matroc (talk)

Thanks! I earlier added some instructions for using your makegeo function with AWB at Wikivoyage talk:AutoWikiBrowser#Updated instructions, but will incorporate the additional code for trimming precision before running it again. -- Ryan • (talk) • 06:06, 28 February 2016 (UTC)[reply]

	The Wikivoyage Barncompass
	This Barncompass is in thanks for your adding all those missing geo tags, and for all the other great work you do! All the best, Ikan Kekek (talk) 16:26, 20 March 2016 (UTC)[reply]

Thanks Ikan! You're overdue for a barncompass yourself, given all of the tireless work you do chasing down touts. I'm honestly not sure how you keep it up - I was finding patrolling unrewarding and finally decided to mostly limit my focus to watchlist articles and other tasks that I find interesting in order to ensure that contributing to Wikivoyage remained a pleasant diversion rather than morphing into a task that I did out of necessity rather than enjoyment. Addressing SEO issues and finding problems that can be fixed in a semi-automated way has sort of reinvigorated my interest in the site, but hopefully I'm not driving anyone else crazy by occasionally filling up Special:RecentChanges with a few hundred minor edits :) -- Ryan • (talk) • 16:49, 20 March 2016 (UTC)[reply]

You shouldn't be, as we can just easily look for the last 250 or 500 changes instead of 50 or 100. Ikan Kekek (talk) 22:07, 20 March 2016 (UTC)[reply]

Excellent idea. I have been thinking for some time we need to address old links but did not know how to do this except manually checking. I assume you have to run the bot though a region. Can you at some point run it over Germany and the United Kingdom? Cleaning this area up will really help readers of Wikivoyage as well as up our search engine ranking. --Traveler100 (talk) 07:13, 7 April 2016 (UTC)[reply]

Per policy the bot needs approval - WV:Script nominations - after which I would eventually run it against all articles on a regular basis. In my tests tonight it's been hugely useful, so hopefully two admins will give their OK and there won't be objections. Until it gets OK'd I'm happy to run it against a small subset of articles for you if you can provide a list. -- Ryan • (talk) • 07:18, 7 April 2016 (UTC)[reply]

Should, perhaps, the bot be cognizant of formatting markup associated with the link and keep the tag outside of it? Example: [1]: the tag is inside the bold markup; seems like it would be better to be outside. Powers ^(talk) 01:38, 23 May 2016 (UTC)[reply]

If that's important to enough people I could look into it, but I'd rather leave things as they are - it's relatively simple to place a template after the closing bracket of a footnote link, but I suspect there will be a ton of edge cases to handle if the code has to try to parse all manner of wiki syntax to figure out placement (bold, italic, HTML, templates, etc). Since the template HTML is invisible to everyone except those users who have explicitly chosen to see it my inclination would be to keep it as simple as possible rather than risk triggering edge cases that might cause inclusion of the template to break something. -- Ryan • (talk) • 19:44, 23 May 2016 (UTC)[reply]

I notice you left an edit comment:

• (diff | hist) . . Amqui‎; 23:33 . . (-805)‎ . . ‎Wrh2 (talk | contribs)‎ (rm comment with non-wikivoyage template code)

This isn't quite true; {{Info Ville}} is indeed Wikivoyage template code, in the original article fr:Amqui. Just because the template doesn't exist in en.voy, that's no reason to claim it doesn't exist anywhere in Wikivoyage. Our Amqui is a translation of the French-language page. K7L (talk) 00:01, 11 April 2016 (UTC)[reply]

I should have specified "non-English Wikivoyage template code". If there's a reason to keep the commented-out template in the article please go ahead and restore it. -- Ryan • (talk) • 00:07, 11 April 2016 (UTC)[reply]

Hi Ryan, I'm bugging you again with the known issue in the subject. In it:voy we are experiencing a problem that needs its resolution so I was hoping that you may have some spare time to take a look at it. To explain you better the issue I've prepared this example page where you can see 3 listings in the description but only 2 listing in the map and only 1 that works correctly. Let me provide you more details about those listings to help you to understand better.

The first listing is a regular one, in fact it's shown correctly in the map, and the listing editor works in the right way.

The second listing is managed correctly by the listing editor, but unfortunately is not shown in the map because the parser that create the map do not recognize the template that incapsulate the see template.

The third listing is shown in the map but with the wrong number (just becuase of the issue in the second listing otherwise it would have the right number), but unfortunaely the listing editor is not able to manage it because of the equal sign of the "Da aggiornare" template that in this case has been inserted inside the description parameter.

Note: The template "Da aggiornare" (whose meaning is 2Bupdated) categorize the the information that has inside, in order to allow us to easily find and change the out of date information.

So, instead of request the adding of the "Da aggiornare" template in the map parser, I think would be better (if possible) to solve the equal sign issue, becuase it would be a more general patch, and it would allow the use of any template and external link inside the listing parameters.

Let me know you thoughts, --Andyrom75 (talk) 04:35, 23 April 2016 (UTC)[reply]

The equals sign bug remains an open issue - see Wikivoyage:Listing editor#Bugs and feedback. I think the only solution will be to do add a lot of additional parsing logic when processing listing templates, which will take some time to implement and test, so unfortunately I don't think it will be done soon. -- Ryan • (talk) • 05:32, 23 April 2016 (UTC)[reply]

No problem. If you think that one day you could try to patch, take your time. We'll patiently wait for it. Thanks in advance. --Andyrom75 (talk) 12:12, 23 April 2016 (UTC)[reply]

I'll definitely let you know when it is fixed. In the mean time, some of the recent 2.0.x bug fixes might be useful for Italian Wikivoyage: Wikivoyage:Listing editor#Changelog / Special:Diff/2945102/2973714. -- Ryan • (talk) • 15:11, 23 April 2016 (UTC)[reply]

Thanks a lot for highlighting me those changes. Although we do not have (at the moment) non standard listing, I've implemented all the changes to keep consistency between the scripts. And thanks for patching the "diff reload" bug, it was very annoying! PS To remove a couple of alerts you could add the semicolumn on the rows 1009 and 1077. --Andyrom75 (talk) 11:19, 25 April 2016 (UTC)[reply]

Regarding the reloaded page I would give you a suggestion that it should be quick to be implemented. Instead of reloding "article" you could reload "article#section" in order to show immediately the section affected by the change. Considering that you already use the "section name" to build the summary of the change, this change should be enough easy. --Andyrom75 (talk) 16:57, 26 April 2016 (UTC)[reply]

I've applied this patch to solve the point that I've highlighted in the previous message. Please take a look at it for your evaluation in order to apply it here as well. --Andyrom75 (talk) 14:29, 10 May 2016 (UTC)[reply]

Thanks! I'll try to get change that integrated in the next couple of days. -- Ryan • (talk) • 16:59, 10 May 2016 (UTC)[reply]

I've updated MediaWiki:Gadget-ListingEditor2.js (the beta listing editor) with a slightly modified version of your changes, and I've also updated a deprecated "edit" param (changed to "csrf"). Thanks again for the patch. -- Ryan • (talk) • 05:57, 11 May 2016 (UTC)[reply]

I think that you should revert your last edit. Think about this case: if you click over "eat" in the banner you'll transform the URL in base#eat, but if you edit a sleep listing, after the save you should land to URL#sleep, but with your last edit you'll keep on landing on URL#eat; because "currentUrlWithoutHash == canonicalUrl". What do you think? --Andyrom75 (talk) 22:22, 11 May 2016 (UTC)[reply]

I think your example describes how the listing editor has always worked, or am I misunderstanding? The advantage of a reload is that when there isn't a hash in the URL, a reload will load the page to the same position as when it was edited, thus putting the edited listing front and center, which is useful for lengthy sections. I don't feel strongly one way or the other, so if you prefer to always load to the section heading instead of doing a reload then I'll update the en: code so that it stays in sync with it:. -- Ryan • (talk) • 22:49, 11 May 2016 (UTC)[reply]

Ahh I got your point. I've got another idea to put on the table. What about reloading URL#listing_name? In this way we'll focus exactly on the changed listing and this will help when the affected section is quite long. --Andyrom75 (talk) 07:30, 12 May 2016 (UTC)[reply]

The latest changes are now active (Special:Diff/2977948/2997723). I think the listing editor works pretty well with the current changes, but if you decide to modify the code in it: to reload to #listing_name let me know and I'll incorporate that change into the English listing editor so that the code stays in sync. -- Ryan • (talk) • 01:39, 17 May 2016 (UTC)[reply]

Hi Ryan, finally I've found some spare time to think about it. I'd like to perform the change of the "listing̜̜̙_name". The best solution would be to retrive that info directly inside saveForm function, but I haven't figured out how. So my suboptimal solution would be to pass "listing.name" (or "listing.nome" in Italian) from formToText function to saveForm funciont, and propagate it to captchaDialog function as well. This should work fine, but before implement it, I'd like to double check with you if it's really impossible to retrive "listing.name". Furthermore I would prefer to not use the word "name" that is linked to a specific language version. What do you think? --Andyrom75 (talk) 15:05, 28 May 2016 (UTC)[reply]

I've suppress a function since en:voy and it:voy code are the same. I don't recall why it was created. Look this change. --Andyrom75 (talk) 15:30, 28 May 2016 (UTC)[reply]

After suppressing the previous function, maybe I've understood its purpose. The problem on the above mentioned equal sign, in reality is on the pipe ("|"), because when one parameter contains another template, the simple split('|') return the wrong result, so inside that function must be written a more complex code (as you have explained above). I'm going to restore it just with a different comment. --Andyrom75 (talk) 15:44, 28 May 2016 (UTC)[reply]

Have a look at User:Wrh2/Gadget-ListingEditor-it.js, which is the English Wikivoyage listing editor ported so that it included customizations from Italian Wikivoyage. The listingTemplateToParamsArray function contains logic that is only in use on Italian Wikivoyage. -- Ryan • (talk) • 16:06, 28 May 2016 (UTC)[reply]

Actually that logic is not in use, however, I've just modified it in order to try to (partially) solve the problem of the equal sign. With this change, I've managed the inner templates. Please take a look and let me know your thoughts. --Andyrom75 (talk) 16:19, 28 May 2016 (UTC)[reply]

I'll be on vacation on the next days, so I won't be able to "play" with JS, but please let me know what do you think about my proposal on the listing_name and the change for the inner template. I should be able to find a connection to communicate. Thanks, --Andyrom75 (talk) 18:58, 1 June 2016 (UTC)[reply]

Life has been very busy lately and I haven't had a chance to review the latest changes, but I'll let you know when I do. -- Ryan • (talk) • 04:00, 2 June 2016 (UTC)[reply]

Don't worry, I really understand you. I've modified the link of the change because I had forgotten the init of a variable. Now I've fixed it too. --Andyrom75 (talk) 09:50, 17 June 2016 (UTC)[reply]

I hope that your life is more relaxing during this summer to allow you to take a look at the changed that I've implemented months ago on it:voy. Since now no issue has been arisen, however your skilled double check could be worth. Cheers, --Andyrom75 (talk) 08:37, 3 August 2016 (UTC)[reply]

Hi Andyrom75. I've looked at the code on Italian Wikivoyage but haven't implemented it on English Wikivoyage yet - for now I've been working on adding Wikidata integration. Note that in addition to templates the editor also needs to handle patterns like [[File:Example.jpg|link=Target]] - I've got that on my TODO list but haven't gotten to it yet. -- Ryan • (talk) • 04:31, 4 August 2016 (UTC)[reply]

If you think that the code is fine I can patch in a similar way also the "[[File:Example.jpg|link=Target]] case". Just let me know if this will put you in the position to align the code. --Andyrom75 (talk) 07:04, 23 August 2016 (UTC)[reply]

I'm uncomfortable with the find & replace approach used to fix the issue in the Italian listing editor, but I haven't implemented a better fix for the English listing editor yet, so if you want to put your change in place for now I don't have any objection. Fixing this issue is the next thing on my TODO list for the English listing editor now that the Wikidata integration is in place. -- Ryan • (talk) • 02:29, 24 August 2016 (UTC)[reply]

I'm not sure to have understood your will. Do you want me to fix also the "link=" case before implementing it into en:voy or do you prefer to solve the issue with a different method by yourself? In this second case I would avoid to work on it. --Andyrom75 (talk) 14:38, 28 August 2016 (UTC)[reply]

I have concerns about using find & replace as a way to fix this issue, so I will eventually work on a different fix for English Wikivoyage, but I think it would be wrong for me to tell you not to put your fix in place now since I'm not actively working on a fix of my own. Apologies if I wasn't clear earlier. -- Ryan • (talk) • 16:03, 28 August 2016 (UTC)[reply]

Don't worry, most likely the issue is rooted on my English skill :-P The "link=" case is not so urgent like the one already fixed, so since "one day" you'll work on it, I have no problem on waiting for you.

I take the chance to ask you a question relevant to your amazing improvment. I would like to implement it on it:voy but I would have few questions. Is this feature completed or it is still in progress? In the second case I would keep on waiting. Another thing. In it:voy we don't accept non-standard values, and during and update, the editor will correct the listing adding missing parameters and removing non-standard ones. Now, I would like to keep the current approach treating wikipedia, wikidata and image parameter as optional; if present they will be kept, otherwise, they won't be added. Is it possible? Let me know, --Andyrom75 (talk) 20:55, 28 August 2016 (UTC)[reply]

@Andyrom75: I've just pushed a change to MediaWiki:Gadget-ListingEditor.js that I believe resolves the issue with embedded pipe characters and equal signs: Special:Diff/3060595/3062488. I've been testing it for a few days and it seems to work against listings that failed previously. I'm going to keep an eye on edits in the coming days to make sure that there aren't any unexpected side-effects as a result of this change, but I think it should be fairly robust. -- Ryan • (talk) • 17:15, 6 October 2016 (UTC)[reply]

Good to know. I'll have a look at it, and I'll try to update also the script in it:voy replacing the current system with the new one. --Andyrom75 (talk) 20:17, 6 October 2016 (UTC)[reply]

Done. It's seems to work. You can remove the comment "Handle "=" in listing parameter values ("[[File:XYZ.jpg|link=ABC]])"". PS because of a mediawiki bug you should add type=general in the resource loader like I've done here (see console alert). --Andyrom75 (talk) 15:41, 8 October 2016 (UTC)[reply]

The Wikidata integration is complete and has been live on English Wikivoyage for over two weeks now, although there will probably be enhancements in the future (see some of the comments at Wikivoyage:Travellers' pub#Updated listing editor with Wikidata & Wikipedia support for suggested improvements). The way the editor is currently set up the "Wikidata", "Wikipedia", and "Image" tags are always shown in the listing editor, but the Javascript "skipIfEmpty" param is set to "true" for all of those values, so if there is no value entered it will not be saved in the listing template when the article is saved. You can try it out here on English Wikivoyage and let me know if you need any modifications for Italian Wikivoyage - as time allows I'd be happy to make any changes to make it easier to use for you. -- Ryan • (talk) • 06:24, 30 August 2016 (UTC)[reply]

I've made few tests and it seems that works exactly as I desire. Here in en:voy the editor is configured to keep all the non-standard parameters right? I've read previously in the lounge about this news and about the possible changes (that's the reason of my question). Do you expect minor or major changes? In the second case I would wait for it, in order to migrate the code only one time. Let me know, --Andyrom75 (talk) 17:43, 30 August 2016 (UTC)[reply]

Thanks for testing. Yes, English Wikivoyage keeps all non-standard parameters because the listing editor ALLOW_UNRECOGNIZED_PARAMETERS flag is true; I believe that value is false on Italian Wikivoyage, so any non-standard parameters is deleted when the listing is saved. I'm not expecting to make any major changes to the Wikidata integration - the only suggested change I'm planning to implement (so far) is to return better data for the "Wikidata" typeahead search so that users who type in "Paris" can more easily differentiate between Paris and Paris (Texas) (for example). -- Ryan • (talk) • 17:54, 30 August 2016 (UTC)[reply]

Ok I'm proceeding with the implementation. I hope that everything would be fine, otherwise I'll ping you for support. Thanks for your great improvements! --Andyrom75 (talk) 19:48, 30 August 2016 (UTC)[reply]

I think that I've applied all the changes but I receive the following JS error message: "TypeError: $(...).autocomplete is not a function TypeError: $(...).autocomplete is not a function(…)"

Any suggestion? --Andyrom75 (talk) 21:13, 30 August 2016 (UTC)[reply]

Sorry, I should have documented that (I actually forgot when I pushed the beta version live on en:). To fix it you will need to add jquery.ui.autocomplete as a dependency in MediaWiki:Gadgets-definition. There are also some CSS updates that will be needed from MediaWiki:Gadget-ListingEditor.css. -- Ryan • (talk) • 21:16, 30 August 2016 (UTC)[reply]

Just added "jquery.ui.autocomplete" on MediaWiki:Gadgets-definition. But how can I test it through the console? ...now I'm going to check the CSS but I already imagine the that you have added wikidata-update class. --Andyrom75 (talk) 21:23, 30 August 2016 (UTC)[reply]

What's the use of listing-sister class? Found it. I'll need to revise also the listing template. --Andyrom75 (talk) 21:31, 30 August 2016 (UTC)[reply]

Without knowing how to use the script in the console (without "jquery.ui.autocomplete") I've kept active the old editor, injecting the new one in the console. In this scenario, when I try to open the form, I receive the following JS error "VM49096:1105 Uncaught TypeError: Cannot read property 'index' of null" on getListingWikitextBraces. The source code is on it:MediaWiki:Gadget-ListingEditor2.js. Any suggestion? --Andyrom75 (talk) 21:43, 30 August 2016 (UTC)[reply]

Without being able to test the code it's hard to tell what's wrong. You might want to create a beta listing editor on Italian Wikivoyage like we've done here for testing purposes - see "ListingEditor2 (beta)" in Special:Gadgets for an example. -- Ryan • (talk) • 00:25, 31 August 2016 (UTC)[reply]

It was a temporary issue (i.e. cache). This morning I get up and the error has disappeared. Now I'll work on the HTML mask, once done I'll make some test. PS I would prefer to test it on the console instead of creating a test gadget. I know that is easier as you have done, but I would avoid it. Any idea on how to add "jquery.ui.autocomplete" through the console? --Andyrom75 (talk) 06:41, 31 August 2016 (UTC)[reply]

I haven't found any use of "listing-span_2_of_2"; can it be deleted? PS Change "0%" into "0" to remove an useless annotation on the .css --Andyrom75 (talk) 07:57, 31 August 2016 (UTC)[reply]

How was possible to remove the "font-size:0.8em;" fix in en:voy? In it:voy is still necessary. --Andyrom75 (talk) 08:22, 31 August 2016 (UTC)[reply]

I've found an issue. If I insert "Q2942518" on wikidata field it is found but without any name, and it I retrive Wikidata info, the field Wikipedia won't be filled, although Wikipedia article exists (at least in Italian). I think the problem is on wikidataEnwiki. Now, I've applied the easiest change Enwiki->Itwiki. Maybe it would be better to configure the language above in order to keep the same code below. I let you change the code as you prefer, then I'll uniform to it. --Andyrom75 (talk) 09:54, 31 August 2016 (UTC)[reply]

I think that would make sense to truncate the coords to only 6 decimal digits. What do you think? --Andyrom75 (talk) 11:00, 31 August 2016 (UTC)[reply]

All of the above suggestions are good ones (CSS cleanup, fix hard-coded "english Wikipedia" reference, truncate geo). I'll try to get them done tonight after work. -- Ryan • (talk) • 14:03, 31 August 2016 (UTC)[reply]

Please note also where I have positioned the the wikidata link on it:voy. I think it is more comfortable in this location, because you don't have to move a lot the mouse pointer, and when the good wikidata instance is the first one you can just double click. PS Let me know about "font-size:0.8em;", its removal on it:voy doesn't work. --Andyrom75 (talk) 14:25, 31 August 2016 (UTC)[reply]

I would also add a simple check on the Wikipedia and Commons field to prevent that users will insert valuse like "http://..." and "File:...". --Andyrom75 (talk) 14:32, 31 August 2016 (UTC)[reply]

In this instance there are two valid websites (one for the building and one for the museum). We should find a way to show both and select the one that will be applied to the listing. --Andyrom75 (talk) 15:35, 31 August 2016 (UTC)[reply]

I've made the three updates you suggested initially:

1. Remove/cleanup CSS
2. Make the "enwiki" field a configurable constant.
3. Trim Wikidata lat/long to six decimal places.

Thanks for your other suggestions - I'll have to look at them later when I have more time, which unfortunately may not be for a while as I'm traveling quite a bit in the coming weeks. I couldn't find anything in the listing editor history that mentions "font-size:0.8em;" except for the license text CSS, so unfortunately I can't answer your question about that. -- Ryan • (talk) • 04:39, 1 September 2016 (UTC)[reply]

I've just implemented everything; thanks for your fixes. Regarding the font you can see this change in MediaWiki:Gadget-ListingEditor.css. For the other points:

1. Wikidata link position
2. Value check on Wikipedia and Commons field
3. How to manage multiple values on Wikidata

No problem for wait a little bit more. However, I understand that point 3 would require time, expecially to decide the approach, while for point 1 you can just take a quick look on it:voy, if you like it, you can just move the "HTML code" as it is, and for point 2, that is quite easy, if you want I can take in charge the code development and test, so once done you can just copy it. Let me know, --Andyrom75 (talk) 06:39, 1 September 2016 (UTC)[reply]

Thanks for the clarification re: font-size - I only looked at the recent listing editor changes and didn't go all the way back to February. MediaWiki:Common.css now contains the following:

.listing-metadata { 	font-size: 0.8em; } 

-- Ryan • (talk) • 13:29, 1 September 2016 (UTC)[reply]

Which is the advantage of moving "font-size: 0.8em;" from "span.vcard-edit-button a" (inside MediaWiki:Gadget-ListingEditor.css) to listing-metadata (inside MediaWiki:Common.css)? PS There is another .listing-span_2_of_2 in MediaWiki:Gadget-ListingEditor.css to be removed. --Andyrom75 (talk) 14:53, 1 September 2016 (UTC)[reply]

On English Wikivoyage the "listing-metadata" style is used with Template:Listing and thus should not be defined in the listing editor CSS. If Italian Wikivoyage only uses that style for the listing editor then it would make sense to keep it in the listing editor CSS for the Italian version. -- Ryan • (talk) • 15:11, 1 September 2016 (UTC)[reply]

I think I've understood what you say, but I have one doubt: it affect only the "[edit]" link connected to listing editor or something else? In the first case it should stay in the editor.css, otherwise is correct the common.css.

I've found a bug on it:voy implementation. Wikipedia field retrive and suggest English results. Maybe is something that should be centralized too. --Andyrom75 (talk) 15:26, 1 September 2016 (UTC)[reply]

I've made this change in order to close this bug. You can implement it on en:voy as well. PS The problem was that www.wikipedia.org is a redirect of en.wikipedia.org. --Andyrom75 (talk) 16:15, 1 September 2016 (UTC)[reply]

Now I've got why you keep "font-size: 0.8em;" in common.css, because in en:voy you use the "last edit" feature, that is shown also when the editor is off. Considering that for it:voy is the same, I would align the code to minimize the discrpancies. In the same spirit, since that you have specified in commons.css "this style should match span.vcard-edit-button a" we can delete .listing-lastedit (i.e. color: rgb(150,150,150);) and "span.vcard-edit-button a" (i.e. color: #969696;) adding (for example) "color: #969696;" to .listing-metadata that will include both.

In this scenario also "listing-sister-icons" shall be move from editor.css into common.css because is used also without the editor, while "listing-sister" can remain where it is (although would be nice to use it always or never).

I've also seen that in the code is used "listing-metadata-items" but I haven't found its definition. Is the definition somewhere else or can it be removed?

Same thing with "listingeditor-edit" added by the JS but I can't find its definition. In this case the style is inherited from "vcard-edit-button". --Andyrom75 (talk) 06:57, 2 September 2016 (UTC)[reply]

I'm going to be traveling a lot in the coming weeks but will get to all of these changes as soon as time permits. Thanks for your thorough review! -- Ryan • (talk) • 03:01, 3 September 2016 (UTC)[reply]

Hoping to meet your favours, I've written the code relevant to the Wikipedia and Image check. See this change. If you like it, feel free to implement it on en:voy as well. Note: the full check would consist an ajax query, but I haven't tested its performance, so I have prefered to implement these basic checks client side, inline of what you have done for the other fields. --Andyrom75 (talk) 07:15, 3 September 2016 (UTC)[reply]

Do you want me to create the new MediaWiki:Gadget-ListingEditor.js that implement all the changes done in it:voy so that you can easily subsitute to the beta version in en:voy in order to be tested? Let me know how and if I can help you considering your busy travelling working days. --Andyrom75 (talk) 13:55, 6 September 2016 (UTC)[reply]

If you have free time then that would likely be useful, but if you've got other things to do I don't think it will be difficult to do the integration. My schedule is pretty insane for the near future, so it may be a couple of weeks before I have much time to work on the listing editor again. -- Ryan • (talk) • 04:06, 7 September 2016 (UTC)[reply]

Since it's something I've done, it took me just one minute. This page contains the script based on en:voy script + language hard coded removal + validation for Wikipedia page & Commons image + new position for wikidata link for data update. Once copied in the beta version, you can delete it.

On top of those changes remains out the following aspects (as a wrap up; no urgency):

1. How to manage multiple values on Wikidata (sometimes more coords, websites and images are stored)
2. CSS review and fix (see my note above, but maybe a full check is needed)
3. Equal sign fix (as discuss you would like to rethink the fix I've applied in it:voy, so I haven't included in the file that I've created before)

Good work, --Andyrom75 (talk) 07:03, 7 September 2016 (UTC)[reply]

Can you inject the above script in the beta version in order to verify its functionality in en:voy as well? --Andyrom75 (talk) 14:36, 21 September 2016 (UTC)[reply]

I've been traveling most of the last two weeks but will get these changes done when I have more time available. If they are critical please just go ahead and change whatever you think is necessary and I'll review it when I have more free time. -- Ryan • (talk) • 15:26, 21 September 2016 (UTC)[reply]

I've already prepared you the complete script to be copied over the beta one, but only an admin can do it, and in en:voy I'm a normal user. That's why I'm disturbing you... sorry :-( PS Next week it's my turn to travel, maybe we'll catch up somewhere over the planet :-D --Andyrom75 (talk) 07:50, 22 September 2016 (UTC)[reply]

I've read again your last message. Maybe there's a misunderstanding. I've done already several patch in operation on it:voy and the script I've prepared here already include them. You can copy this script on the beta version for your double check before the implementation over the main one. The remaining patch can wait when you'll have more time. I hope this time I've been clearer :-) --Andyrom75 (talk) 07:39, 25 September 2016 (UTC)[reply]

@Andyrom75: I'm finally done traveling for a while, so I've tested & integrated the changes from User:Andyrom75/MediaWiki:Gadget-ListingEditor.js into the English listing editor - thanks for making that available. You may want to add Special:Diff/3043096/3059819 to the Italian listing editor - it fixes a bug where if an article starts with an h3, attempts to edit any listing within an h2 that does not also contain an h3 will fail (see User:Wrh2/Sandbox). -- Ryan • (talk) • 17:05, 1 October 2016 (UTC)[reply]

Thanks to you! I'm coming home right now waiting at the airport :-) I've already implemented that change in the past few days. I've thought that the code was equivalent but more syinthetic; only now I understand from you that in the reality is different and is used to solve a bug.

Curiosity: why have you moved WIKIDATA_SITELINK_WIKIPEDIA in a different place?

PS Few minor things.

• Since you have changed the Wikipeda and Commons regex, you should delete the "INvalid" comments because they are not anymore true.
• Add ";" at the and of the three _validateFieldAgainstRegex calls.
• Change the comment of the Commons function into

* Implement SIMPLE validation on Image field.  Not existing images can * still get through, but this method implements the validation in * order to avoid users to add the image prefix before the image name 

Last point is my fault; bad copy and paste last time (sorry). --Andyrom75 (talk) 19:11, 2 October 2016 (UTC)[reply]

┌────────────────────────────────────────────────────────────────────────────────────────────────────┘

The three changes you've suggested are now done. I moved WIKIDATA_SITELINK_WIKIPEDIA to the "Config" section since "Config" should be the only section that MUST be updated for each language version's implementation of the listing editor, and using ListingEditor.Config.LANG+'wiki' as the value felt like it could potentially be unsafe since there isn't a spec that says Wikidata will always use language code + "wiki" for the sitedata property name. Thanks for reviewing the changes! -- Ryan • (talk) • 05:10, 3 October 2016 (UTC)[reply]

For WIKIDATA_SITELINK_WIKIPEDIA you are right, I haven't thought about it.

What do you think to write WIKIPEDIA_URL = '//'+LANG+'.wikipedia.org' and WIKIDATA_SITELINK_WIKIPEDIA = LANG+'wiki' to state more clear the language dependency and to facilitate the implementation on the other language? --Andyrom75 (talk) 11:41, 5 October 2016 (UTC)[reply]

My preference would be to leave things as they are since there is no spec or rule that says that pattern will always work. However, it currently works with all languages used by Wikivoyage, so if you prefer to do things differently on Italian Wikivoyage then that should be fine. -- Ryan • (talk) • 17:54, 6 October 2016 (UTC)[reply]

To change only one script doesn't make any sense. So, since you don't feel confident, I'll change also the one in it:voy. --Andyrom75 (talk) 20:14, 6 October 2016 (UTC)[reply]

I've notice that you haven't implemented the new Wikidata link position. You just miss it or you don't like it? In my opinion is more user-friendly, but it's up to you. Remember to check the CSS styles. See my above note that starts with "Now I've got why you keep ....". --Andyrom75 (talk) 15:52, 8 October 2016 (UTC)[reply]

Sorry it took a while to respond. I'll update the comments, review the placement of the Wikidata link, and check the CSS the next time I'm working on the listing editor. -- Ryan • (talk) • 03:28, 14 October 2016 (UTC)[reply]

I note you deleted Savonia, with a reference to "Pcv", i.e. the talk page of Wikivoyage:Deletion policy. I cannot find any relevant discussion on that page (perhaps there is a non-obvious connection to some of them, but reading all discussions to perhaps find the hint would be too much work). Could you please explain in some more explicit manner?

Savonia is a region ("a real place"), although not a formal one anymore, and often referenced when talking about Finnish culture and geography. The fact that we do not use it in our geographical hierarchy is no reason to have it redlink.

The obvious thing to do would be to have Savonia link to the articles we have on the region (South Savonia and North Savonia), or preferably to the broader Finnish Lakeland. Any usable content from the deleted article versions could be moved there (Savonians are mentioned in the Talk section, but I think Understand is better for this).

--LPfi (talk) 11:13, 3 May 2016 (UTC)[reply]

The user discussed at pcv is a long term cross-wiki vandal - see also User talk:Longboarder2000, and the many sock puppets referenced in the "pcv" discussion - and his contributions are typically deleted as soon as they are recognized. If you would like to recreate the article please do so. -- Ryan • (talk) • 13:54, 3 May 2016 (UTC)[reply]

OK. My browser was confused and did not land at the right point, and for some reason the acronym did not ring any bells for me. In this case the article was redlinked by another user and I thought it also was him who created it. I now created the redirect. --LPfi (talk) 20:33, 3 May 2016 (UTC)[reply]

	mister
	to je pro tebe Drancakova.barb1 (talk) 18:15, 7 May 2016 (UTC)[reply]

Dear ryan ( Wrh2 )

I'm ikan sarden,may I know your email address? Because you block edit from Lake Toba Tour. This is the link : https://en.wikivoyage.org/wiki/Lake_Toba#By_bus I just want to added information about Lake Toba Transport. Please help our area "Lake Toba" North Sumatera, Indonesia grow. So easy for our travellers to find information about lake toba transport services to our area ryan. Please give me your official email account,so I can communicate with you directly.

Regards Ricky ( Ikan Sarde )

I don't know how to do a "proper move". Can you do it? —The preceding comment was added by Ar2332 (talk • contribs)

It's already done. See also Wikivoyage:How to rename a page. If text is just copied & pasted from one article to another then the article history does not show all contributors, and contributors must be given proper credit for their edits in accordance with the CC-SA license. -- Ryan • (talk) • 18:12, 16 May 2016 (UTC)[reply]

Thank you for rescuing a newbie.Wpwatchdog (talk) 21:27, 25 August 2016 (UTC)[reply]

Hi Ryan, I just deleted the userpage created by an anonymous user for User:Electricbassguy (an account that is globally locked). I didn't see that you deleted and restored it before. It had a speedy deletion tag and I reasoned that completely anonymous users should not create user pages, especially when users are blocked (and thus can't respond). However, you seem to think it's probably the user himself? I have no strong feelings about this either way, so feel free to undo my deletion. Best, JuliasTravels (talk) 21:20, 26 August 2016 (UTC)[reply]

Deleting it was the right thing to do. I saw an anonymous user add a "blocked" notice to a page and I deleted it immediately since that's nearly always vandalism, then realized that the userpage in question was actually a globally blocked user, so I reverted my deletion out of an abundance of caution. It was then flagged as speedy delete by User:Syum90 who is a sysop on meta, so speedy deletion is definitely the right outcome. -- Ryan • (talk) • 21:55, 26 August 2016 (UTC)[reply]

Oh, that's just mean spirited :)
I's a good sign though, I figure most are new? Or does the script miss a few each run? Acer (talk) 20:02, 27 August 2016 (UTC)[reply]

Sorry, since Wikidata integration was introduced for interwiki links there hasn't been as much urgency to include "wikivoyage" templates in Wikipedia articles, but when I saw you were updating things I figured I should re-run the scripts to get you the latest data. Most of the articles are either new, articles that have changed status, or articles that have changed due to edits or page moves on Wikipedia. If the scripts miss anything it's a bug in my code. -- Ryan • (talk) • 20:10, 27 August 2016 (UTC)[reply]

It's alright, the mean spirited part is actually a movie quote, was trying to be funny. It actually helped me since I didn't have to manually remove the ones I'd already done from the list. I'll get to work on the new ones, cheers Acer (talk) 20:23, 27 August 2016 (UTC)[reply]

Ok, having done a few I think I got a picture of what's happening. Most of these were expanded in the last couple of months, so yes, status change. The second largest group are new pages. I've only found one case of a WV template being removed, guy tried to remove some vandalism and nuked the template along by mistake. No page moves so far Acer (talk) 10:48, 28 August 2016 (UTC)[reply]

Could you rerun the scripts? I've gone over all the lists except the undeveloped articles, thanks Acer (talk) 22:05, 2 September 2016 (UTC)[reply]

Done -- Ryan • (talk) • 00:47, 3 September 2016 (UTC)[reply]

I don't know how customizable it is, but would it be possible to have your script subdivide the undeveloped articles list?, every two thousand or three thousand bytes? I'm adding links to the better ones but quality varies a lot in that group, thanks Acer (talk) 15:51, 21 September 2016 (UTC)[reply]

The "undeveloped" list was originally meant to contain those articles that contained too little information to warrant a link from Wikipedia. If you'd like I can reduce the threshold for "undeveloped" from 10,000 bytes down to a smaller number, but there has been concern in the past that if we added Wikivoyage links to Wikipedia articles for poor quality Wikivoyage article that Wikipedians would begin removing them due to violations of Wikipedia external link guidelines, so I think in general we should be cautious about adding links for these articles. -- Ryan • (talk) • 18:06, 21 September 2016 (UTC)[reply]

Ok, that works. 7k? I've found quite a few that include text, most sections and listings but don't quite reach the 10k threshold. I've been skipping the one-liners and those with little text and many empty sections but I have to open each one to check. This would save time since the less developed ones tend to be smaller. Acer (talk) 18:51, 21 September 2016 (UTC)[reply]

Done -- Ryan • (talk) • 21:10, 21 September 2016 (UTC)[reply]

• There is a proposal for libLua.js, a library for calling Lua functions from JavaScript. -- Matroc (talk) 05:20, 26 September 2016 (UTC)[reply]

Hi Ryan! One of our editors on Russian WV localized the latest version of the Listing editor. However, it does not work properly, because the autocomplete() function from the jquery-ui library is not activated. But this function is activated on English WV! How does it work? Have you changed anything in the Mediawiki configuration yourself, or have you filed a Phabricator request?

Thanks in advance for your advice! --Alexander (talk) 16:50, 4 November 2016 (UTC)[reply]

I have added a line to Mediawiki:Gadgets-definition, but it does not help. --Alexander (talk) 17:15, 4 November 2016 (UTC)[reply]

Is it still broken for you? The change you made to ru:MediaWiki:Gadgets-definition should resolve the dependency, although due to caching issues it may take several minutes for that change to take effect. -- Ryan • (talk) • 17:41, 4 November 2016 (UTC)[reply]

Yes, you are right. Now it's working, but this time it was really slow to update. It took at least 15 min. Sorry for bothering you. --Alexander (talk) 20:11, 4 November 2016 (UTC)[reply]

Glad it's fixed. Let me know if you have any issues with the new functionality - aside from User:Andyrom75 there isn't a lot of coordination between languages on the listing editor, but I'd love to make any changes that would make it easier for different language versions to share code and ideas. -- Ryan • (talk) • 20:45, 4 November 2016 (UTC)[reply]

I haven't got the time to analyzed the situation, but the properties d:P969 and d:P669 contains information relevant to the address. Maybe those information can be used to complete the listing. If you have time try to have a look at them. --Andyrom75 (talk) 23:01, 10 November 2016 (UTC)[reply]

Thanks, I'll add that to the TODO list for the next time I'm working on the listing editor. At the moment most of my Wikivoyage time is going into User:Wrh2Bot, but once that settles down there should be some time to look at the listing editor again. -- Ryan • (talk) • 00:36, 11 November 2016 (UTC)[reply]

Hi Ryan, I think we should add this patch to allow the code to be more general. Without it, the code doesn't work on Unicode title on fr:voy. Let me know your thoughts. --Andyrom75 (talk) 12:21, 16 November 2016 (UTC)[reply]

Can you provide an example so I can see what is breaking? I tried testing with a Unicode heading but the listing editor still works as expected for me: User:Wrh2/Sandbox#castello è visitabile. Thanks! -- Ryan • (talk) • 02:15, 17 November 2016 (UTC)[reply]

Oh yes sorry. The problem is on section title. It doesn't add the [add listing] link. --Andyrom75 (talk) 08:12, 17 November 2016 (UTC)[reply]

Please let mw know if you got what I meant. --Andyrom75 (talk) 16:20, 19 November 2016 (UTC)[reply]

Thank you for your clarification. I've been traveling all week and will be traveling again in the coming week, but I have a note on my TODO list to push a fix so that I won't forget. -- Ryan • (talk) • 16:35, 19 November 2016 (UTC)[reply]

@Andyrom75: Sorry for the delay. I've applied your patch in Special:Diff/3081353/3093648. Unless I'm mistaken, the initial escaping of sectionId is unnecessary so I've also removed it, and I've also replaced some custom code with mw.util.escapeId to ensure that we (hopefully) won't encounter similar issues elsewhere. -- Ryan • (talk) • 02:54, 27 November 2016 (UTC)[reply]

Thank you! I've implemented both in it:voy. --Andyrom75 (talk) 15:54, 27 November 2016 (UTC)[reply]

Hi, could you run the broken link check bot over the region Wales for me. I am trying to remove all dead listings for the area. --Traveler100 (talk) 06:53, 25 November 2016 (UTC)[reply]

Sure - give me a day or so as that bot needs to be run from a reliable network in order to be as accurate as possible, and the network in my current location isn't one that I fully trust. I'll let you know when it's been run. -- Ryan • (talk) • 16:18, 25 November 2016 (UTC)[reply]

@Traveler100: Done - see [2]. -- Ryan • (talk) • 06:58, 26 November 2016 (UTC)[reply]

Great, thanks. --Traveler100 (talk) 07:48, 26 November 2016 (UTC)[reply]

Thank you very much for your {{Mapshape}} template that we imported to the German Wikivoyage edition, too. On December 10, 2016 we celebrate the 10th anniversary of the Wikitravel fork which came to life in 2006. So, this is a nice birthday present. The new Finish branch is also a nice present. I by myself made a complete reprogramming of our vCard template (comparable to {{listing}}) with an almost complete support of Wikidata imports. And Skype links are working, too. --RolandUnger (talk) 13:09, 27 November 2016 (UTC)[reply]

Hi Ryan, there's a reason why the "wikidata" parameter cannot be set by default equal to the wikidata ID of the page where this template is used? If possibile, this would simplify the life of a non-techie editor. --Andyrom75 (talk) 16:18, 27 November 2016 (UTC)[reply]

@Andyrom75: I initially tried using {{{wikidata|{{#invoke:Wikidata|pageId}}}}} to default the Wikidata ID to the current page ID, but it didn't work, apparently due to the fact that maplink must be invoked with #tag, which (if I understand correctly) runs before #invoke. If there is another way to get the current page's Wikidata ID then that would definitely be a better solution. -- Ryan • (talk) • 17:04, 27 November 2016 (UTC)[reply]

@RolandUnger: Thanks! Credit for the template mostly goes to User:Yurik - I started out with a different implementation but he suggested the current {{mapshape}} approach. I haven't checked German Wikivoyage lately (mainly due to the fact that I don't speak German...) but will definitely take a look at the changes you've highlighted. -- Ryan • (talk) • 17:04, 27 November 2016 (UTC)[reply]

If the order of execution is the real problem you can use a "buffer template". See this change. --Andyrom75 (talk) 17:52, 27 November 2016 (UTC)[reply]

@Andyrom75: Thanks! I've split the template into Template:Mapshape and Template:Mapshape/Inner and updated the documentation to note that "wikidata" now properly defaults to the page's Wikidata ID. -- Ryan • (talk) • 18:13, 27 November 2016 (UTC)[reply]

Lua error in package.lua at line 80: module 'Module:No globals' not found. For example at Wales but other pages too. --Traveler100 (talk) 17:44, 27 November 2016 (UTC)[reply]

That should have already been fixed - I missed the dependency on Module:No globals and had to import that as well - but it might take a few minutes for caches to clear. -- Ryan • (talk) • 17:47, 27 November 2016 (UTC)[reply]

(edit conflict) I see it too in the Wales article, but nowhere else. However, I saw it in all articles half an hour ago, and was about to take up the issue in the pub. ϒpsilon (talk) 17:48, 27 November 2016 (UTC)[reply]

I apologize for not being more careful. Our version of Module:Wikidata was woefully out of date, but I should have been more cautious when importing the latest version from Wikipedia. -- Ryan • (talk) • 17:51, 27 November 2016 (UTC)[reply]

See User:Andyrom75/Sandbox#Similar template bug.

When a template name starts with the same name of a listing template, it cause issues on all the listing below of it.

The problem occurred in fr:voy. I don't know if the problem is in the regex stated in getListingTypesRegex function, of in the code that use it.

Since you have a more global vision of the whole code maybe it's better that you'll evaluate the best fix.

PS I've made a test on adding "[\\s\\n]*\\|" after the "\\b" but it doesn't work. Let me know, --Andyrom75 (talk) 19:04, 27 November 2016 (UTC)[reply]

Thanks - as you've noted, I think the fix is just to update the regular expressions. I'll try to get to investigate and get a fix out in the next week or so. -- Ryan • (talk) • 03:50, 29 November 2016 (UTC)[reply]

@Andyrom75: I'm still testing, but so far Special:Diff/3093630/3098353 seems to fix the issue (see User:Wrh2/Sandbox#See). I'd like to use it for a couple more days before pushing it live in case there are any edge cases that turn up. -- Ryan • (talk) • 05:00, 5 December 2016 (UTC)[reply]

What's the use of the first brackets? Without them you can convert "$2$3" into "$1$2" and if I'm not wrong "regexResult[1]" into "regexResult[0]". --Andyrom75 (talk) 08:53, 5 December 2016 (UTC)[reply]

Without the first brackets the regex result will include the trailing "|" or "}" character, and will then break the getListingWikitextBraces method. -- Ryan • (talk) • 16:05, 5 December 2016 (UTC)[reply]

mmm, but the inner brackets (this one: (' + regex.join('|') + ') ) already select the type found. Why to not use it? --Andyrom75 (talk) 18:43, 5 December 2016 (UTC)[reply]

I don't think I understand - that sub-pattern matches different text. If it would be easiest, maybe you could implement your preferred solution, and if it works successfully then I could integrate it into the listing editor here? -- Ryan • (talk) • 19:01, 5 December 2016 (UTC)[reply]

The idea is that with "({{\\s*(' + regex.join('|') + ')" you match both "{{see" and "see", but the first one is not necessary. However, since it's just a detail that require to check other parts of code, it doesn't matter. PS Take a look at my sandbox. I've seen that an empty template (extreme example...) generate a JS error. Do you think that worth to consider also this case? --Andyrom75 (talk) 10:37, 8 December 2016 (UTC)[reply]

Special:Diff/3101130/3101131 should fix the bug with empty listing templates. I still don't understand why a match for "{{see" isn't necessary - I'm fairly certain that eliminating that pattern will break the getListingWikitextBraces method - so if you could implement your preferred change then I could review your implementation and hopefully better understand. -- Ryan • (talk) • 17:07, 10 December 2016 (UTC)[reply]

I'm just explain to let you better understand what I mean, but I'm fine with your fix (better to put effort in something else). What I meant is that if you do a match, you do it to reuse the match afterwords. Here we look for different template name (e.g. see, do, drink, etc.) but all of them starts with "{{". So, since the or clause in the regex make a match by design (because of the brackets), the fixed part (i.e. "{{") can be added when necessary, without the need of making a second match.

But I repeat, is just to explain you what I meant. Because I think your fix works, while this one require to adjust the code where it's used and so is not strictly necessary.

PS Thanks for the fix, I'll implement immediately :-) --Andyrom75 (talk) 19:32, 10 December 2016 (UTC)[reply]

• Hi! - I left a note on the discussion page for Template:Mapshape -- might be something I am not doing correctly but not sure. I was using the template with type=geoshape and I get the geomask as a result. Looked like the default mask was not overridden by the type parameter? Hope you had a Happy Thanksgiving! - Cheers! -- Matroc (talk) 03:43, 6 December 2016 (UTC)[reply]

Thank you Ryan. Thank you for your support an understanding. I will come up with a decent guide to the Wreck of the Brianna H in my own time now. I was lucky to hear from you. Best Wishes. Johnmartindavies 22:32, 7 December 2016 (UTC)

I look forward to seeing how the guide develops - please let me know if I can help out in any way. -- Ryan • (talk) • 05:06, 8 December 2016 (UTC)[reply]

Hello Ryan

I've started re-developing the guide to diving the Brianna H.

I've inserted a paragraph that should not be neccessary for the article, but for the education of editors who are not currently diving.

"When divers are introduced to a new wreck they generally like to know as much as possible about the unfortunate ship before it sank, the circumstances leading up to the sinking, and about any casualties so as to accord them proper respect. It can be quite disturbing to unexpectedly encounter a human skull on a wreck, as happened to a friend of mine because of inadequate information. Thus any documented information should be as complete as possible, not truncated for the benefit of editors not currently diving. Furthermore a Dive Guide carries a greater risk of Safety considerations and litigation than a pleasant stroll around Provincetown, Massechusetts."

I've added this advice because my introduction to the Brianna H, based on divers preferences was mutilated by the Wikivoyage Editor.

I will make the rest of the guide more focussed but also informative to divers. Best Wishes Johnmartindavies 20:53, 23 December 2016 (UTC).

Let me know if I can assist. While I think the text you added is fine, if you prefer not to include it directly in the article you can always put a comment on the article's talk page since many editors will review the talk page before making changes to an article. -- Ryan • (talk) • 03:47, 24 December 2016 (UTC)[reply]

Thanks, It's still a stub as it's needs a lot of expansion :( ShakespeareFan00 (talk) 10:33, 28 December 2016 (UTC)[reply]

It can probably be upgraded to outline, but the user who made the change is a longtime troll whose edits are usually reverted on sight. -- Ryan • (talk) • 13:40, 28 December 2016 (UTC)[reply]

I say it's stub until it covers all continents ;)

I was also meaning to ask if Doll's houses counted as miniatures or toys, and whether somethings that's a specfic exhibit in another musuem can be listed in a topic specifc item, even if the general museum isn't for that topic? (The specifc item concerned is w:Queen Mary's Dolls' House which is shown at Windsor Castle, which isn't a destination for "minatures" as such. Sfan00 IMG (talk) 15:07, 28 December 2016 (UTC)[reply]

And given the term minature has other uses, I probably need to add a hat-note in the lead, Where would Minatures in the context of alcohol and ceramics link? Sfan00 IMG (talk) 15:07, 28 December 2016 (UTC)[reply]